RE: [Ethereal-users] Bugs in README.developer

[Richard Urwin <RUrwin@xxxxxxxxxxxxx>]

Ahh, I see. Thanks

-- 
Richard Urwin, Software Design Engineer
Schenck Test Automation
Braemar Court, 1311b Melton Road, Syston, UK.
rurwin@xxxxxxxxxxxxx



-----Original Message-----
From: Guy Harris [mailto:guy@xxxxxxxxxx]
Sent: Monday, July 15, 2002 9:30 PM
To: Richard Urwin
Cc: ethereal-users@xxxxxxxxxxxx
Subject: Re: [Ethereal-users] Bugs in README.developer


On Mon, Jul 15, 2002 at 02:53:17PM +0100, Richard Urwin wrote:
> 2. The line:
> 		proto_tree_add_uint(tree, hf_PROTOABBREV_FIELDABBREV, tvb,
> offset, len, value)
>    Should read:
> 		proto_tree_add_uint(ti, hf_PROTOABBREV_FIELDABBREV, tvb,
> offset, len, value)

No, it shouldn't.

It should read

	proto_tree_add_uint(PROTOABBREV_tree, hf_PROTOABBREV_FIELDABBREV,
tvb,
	    offset, len, value);

(Yes, *currently* "proto_item_add_subtree()" *happens* to return its
first argument, but that's not guaranteed to be true forever.)

_____________________________________________________________________
This message has been checked for all known viruses by UUNET delivered 
through the MessageLabs Virus Control Centre. For further information visit
http://www.uk.uu.net/products/security/virus/

________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs SkyScan
service. For more information on a proactive anti-virus service working
around the clock, around the globe, visit http://www.messagelabs.com
________________________________________________________________________