Re: 2nd Try: [Fwd: [Ethereal-dev]: Question about adding convers ations]

[Manu Pathak <mapathak@xxxxxxxxx>]

Hi Francisco,

   Yes, sorry I forgot to attach packet-rsvp.h. It's attached with
this message. I actually did manage to figure out what the problem
was; the call to tap_queue_packet() was in the wrong place. It
should have been at the end of dissect_rsvp() instead of
dissect_rsvp_msg_tree(). With that change, I was able to get the
basic stuff working. I still need to enhance the conversation stuff,
but the essential problem is taken care of. I will send a patch with
the final stuff when I am done. Thanks for your help! Regards,

Manu

Francisco Alcoba (TS/EEM) said the following on 06/02/2005 01:41 PM:
> Hi,
>
> The code you sent does not compile. I think that at least 
> a modified packet-rsvp.h is missing. I'm trying to get it
> working to find out what's wrong, I find it easier than
> just proofreading it.
>
> Regards,
>  Francisco
>
>
> > -----Original Message-----
> > From: ethereal-dev-bounces@xxxxxxxxxxxx
> > [mailto:ethereal-dev-bounces@xxxxxxxxxxxx]
> > Sent: miércoles, 01 de junio de 2005 5:43
> > To: Ethereal development; francesco.alcoba@xxxxxxxxxxxx
> > Subject: Re: 2nd Try: [Fwd: [Ethereal-dev]: Question about adding
> > conversations]
> >
> >
> >
> > I forgot to mention that I am using the sample capture available
> > from the Ethereal Sample Captures Wiki page at the following URL:
> >
> > http://wiki.ethereal.com/SampleCaptures
> >
> > The file in question is mpls-te.cap. Thanks!
> >
> > Manu
> >
> > Francisco Alcoba (TS/EEM) said the following on 05/30/2005 08:41 AM:
> >
> > > Hi,
> > >
> > > Can you post the code you are trying to use and a sample capture?
> > >
> > > Regards,
> > > Francisco
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: ethereal-dev-bounces@xxxxxxxxxxxx
> > > > [mailto:ethereal-dev-bounces@xxxxxxxxxxxx]
> > > > Sent: sábado, 28 de mayo de 2005 16:49
> > > > To: ethereal-dev@xxxxxxxxxxxx
> > > > Subject: 2nd Try: [Fwd: [Ethereal-dev]: Question about adding
> > > > conversations]
> > > >
> > > >
> > > > Still hoping somebody can help me out on this one...
> > > >
> > > > Essentially, I need to know what needs to be done to generate
> > > > RSVP related information apart from adding the regular conversation
> > > > stuff described in README.developer. I would have thought that the
> > > > task would be analogous to how we handle things to the IPv4
> > > > dissector from the Ethernet frame, but I haven't been able to
> > > > figure this out so far:(.
> > > >
> > > > Thanks in advance for any help! Regards,
> > > >
> > > > Manu
> > > >
> > > > -------- Original Message --------
> > > > Date: Thu, 26 May 2005 14:48:32 -0400
> > > > From: Manu Pathak <mapathak@xxxxxxxxx>
> > > > User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;	rv:1.7.5)
> > > >
> > > > Hi,
> > > >
> > > >   I am working on adding support for RSVP conversations 
> >
> > to Ethereal,
> >
> > > > and using the IP conversations code as the example to follow. So
> > > > far:
> > > >
> > > > - I have added the gtk/conversations_rsvp.c and gtk/hostlist_rsvp.c
> > > > files and successfully got an RSVP entry in the conversations list
> > > > and the conversations tab. To do this, I also edited packet-rsvp.h
> > > > to define the rsvphdr structure.
> > > >
> > > > - Added conversation stuff to packet-rsvp.c as described in the
> > > > README.developer file. I am reasonably sure I have made all the
> > > > changed described in Section 2.2 of that document, which deals
> > > > with conversations. I also populate the rsvphdr structure in
> > > > this file and have added the conversation specific initialization
> > > > routine. For what it's worth, I used the conversations code
> > > > in packet-afs.c and packet-beep.c as example to make these
> > > > changes [As an aside, I could not find where the conversations for
> > > > these protocols are available in the GUI; I would have expected
> > > > them with the rest, but they don't seem to be there. Why is that
> > > > the case?].
> > > >
> > > >   Unfortunately, when I load the sample RSVP capture file from
> > > > the Ethereal Wiki page, I still don't see any information in the
> > > > RSVP tab (though the Ethernet and IPv4 tabs have the information
> > > > as one would expect). Clearly, I am missing something here. I
> > > > think it has to do with the fact that somehow I need to add some
> > > > code somewhere which would be responsible for calling the RSVP
> > > > subdissector. I added something like the following to packet-rsvp.c
> > > > but it did not do the trick:
> > > >
> > > > rsvp_dissector_table =
> > > > 	register_dissector_table("rsvp.proto", "RSVP Protocol",
> > > > 				 FT_UINT8, BASE_DEC);
> > > > 						
> > > > register_heur_dissector_list("rsvp", &heur_subdissector_list);
> > > >
> > > > Can anybody tell me what I am missing? Thanks,
> > > >
> > > > Manu
> > > >
> > > > --
> > > > ------------------------------------------------------------
> >
> > ---------
> >
> > > > "Do you mean now ?"
> > > >                                 -Yogi Berra, when asked 
> >
> > for the time
> >
> > > > _______________________________________________
> > > > Ethereal-dev mailing list
> > > > Ethereal-dev@xxxxxxxxxxxx
> > > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> > > >
> > > >
> > > > --
> > > > ------------------------------------------------------------
> >
> > ---------
> >
> > > > "Do you mean now ?"
> > > >                                 -Yogi Berra, when asked 
> >
> > for the time
> >
> > > > _______________________________________________
> > > > Ethereal-dev mailing list
> > > > Ethereal-dev@xxxxxxxxxxxx
> > > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> > >
> > >
> > > _______________________________________________
> > > Ethereal-dev mailing list
> > > Ethereal-dev@xxxxxxxxxxxx
> > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> >
> > --
> > ---------------------------------------------------------------------
> > "Do you mean now ?"
> >                                  -Yogi Berra, when asked for the time
> >
> > _______________________________________________
> > Ethereal-dev mailing list
> > Ethereal-dev@xxxxxxxxxxxx
> > http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev

--
---------------------------------------------------------------------
"Do you mean now ?"
                                 -Yogi Berra, when asked for the time

/* packet-rsvp.h
 * Declarations of variables exported by "packet-rsvp.c"
 *
 * $Id: packet-rsvp.h 11452 2004-07-21 05:57:30Z guy $
 *
 * Ethereal - Network traffic analyzer
 * By Gerald Combs <gerald@xxxxxxxxxxxx>
 * Copyright 1998 Gerald Combs
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

#ifndef PACKET_RSVP_H
#define PACKET_RSVP_H

/* manu */
/* RSVP conversations support */
typedef struct _e_rsvp
{
    guint8   rsvp_ver_flags;
    guint8   rsvp_msg_type;
    guint8   rsvp_send_ttl;
    guint16  rsvp_length;
    address  ip_src; 
    address  ip_dst;

} e_rsvphdr;

extern const value_string gmpls_switching_type_str[];
extern const value_string gmpls_lsp_enc_str[];
extern const value_string gmpls_protection_cap_str[];
extern const value_string gmpls_sonet_signal_type_str[];

#endif