[Ethereal-dev] Re: [Ethereal-cvs] rev 13225: /trunk/epan/dissectors/: packet-h225.c packet-h225.h packet-h245.c packet-h245.h packet-isup.c packet-isup.h packet-q931.c packet-q931.h packet-rtp.c packet-sdp.c packet-sip.c packet-sip.h ...

[Tomas Kukosa <tomas.kukosa@xxxxxxxxxxx>]

Hi,
  I guess to would be better to change following directive in h225.cnf:

#.FN_FTR NULL
  if (h225_pi->cs_type == H225_OTHER) h225_pi->cs_type = H225_EMPTY;
#.END

to

#.FN_FTR H323-UU-PDU/h323-message-body/empty
  h225_pi->cs_type = H225_EMPTY;
#.END

It will change dissector function only for necessary field instead of all NULL fields.


lroland@xxxxxxxxxxxx wrote:

> User: lroland
> Date: 2005/02/01 06:12 AM
>
> Log:
>  From Alejandro Vaquero:
>  h323 taps support up to 5 messages per packet now.
>  
>  VoIP call analysis:
>        - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info:
>        - Start and Stop time of the call
>        - Init
>
> Directory: /trunk/epan/dissectors/
>   Changes    Path             Action
>   +108 -40   packet-h225.c    Modified
>   +17 -7     packet-h225.h    Modified
>   +113 -20   packet-h245.c    Modified
>   +5 -1      packet-h245.h    Modified
>   +12 -3     packet-isup.c    Modified
>   +3 -0      packet-isup.h    Modified
>   +212 -159  packet-q931.c    Modified
>   +13 -1     packet-q931.h    Modified
>   +32 -0     packet-rtp.c     Modified
>   +17 -0     packet-sdp.c     Modified
>   +22 -1     packet-sip.c     Modified
>   +6 -0      packet-sip.h     Modified
>
> Directory: /trunk/epan/
>   Changes    Path               Action
>   +2 -0      libethereal.def    Modified
>
> Directory: /trunk/gtk/
>   Changes    Path                Action
>   +1009 -0   graph_analysis.c    Added
>   +121 -0    graph_analysis.h    Added
>   +15 -0     rtp_stream.c        Modified
>   +5 -0      rtp_stream.h        Modified
>   +1312 -0   voip_calls.c        Added
>   +191 -0    voip_calls.h        Added
>   +719 -0    voip_calls_dlg.c    Added
>   +55 -0     voip_calls_dlg.h    Added
>
> Directory: /trunk/asn1/h225/
>   Changes    Path                      Action
>   +89 -27    h225.cnf                  Modified
>   +25 -8     packet-h225-template.c    Modified
>   +16 -6     packet-h225-template.h    Modified
>
> Directory: /trunk/asn1/h245/
>   Changes    Path                      Action
>   +45 -15    h245.cnf                  Modified
>   +67 -4     packet-h245-template.c    Modified
>   +5 -1      packet-h245-template.h    Modified
>
> Directory: /trunk/
>   Changes    Path          Action
>   +2 -0      AUTHORS       Modified
>   +1 -0      rtp_pt.h      Modified
>
>
>
> http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=13225&view=rev
>
> _______________________________________________
> Ethereal-cvs mailing list
> Ethereal-cvs@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-cvs