RE: [Ethereal-dev] Bug report: crash in packet-dcerpc-ndr.c

["Eric Wedel" <ewedel@xxxxxxxxxxx>]

iirc, there is a tag field in the private data, which could at least
be used as a start.  I wondered, at the time I was producing the patch
which Ulf mentioned, but was lazy and didn't try to produce something
more global.

The tag field is not (yet) widely used, so now might be a good time
to change it from protocol-specific to a global enumeration.
Unless of course the community would rather adopt an entirely
different approach.  :-)

[Am remote now, can't give a more exact pointer to the field in
question, sorry.]

regards, Eric


-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx on behalf of ronnie sahlberg
Sent: Sun 9/5/2004 3:58 PM
To: Ethereal development
Subject: Re: [Ethereal-dev] Bug report: crash in packet-dcerpc-ndr.c
 
Yes, definitely.

the pinfo->private_data interface is suboptimal and error prone.

It would be better to change this to some sort of list of  protocol,data  pairs
which can be searched. 
It would be a lot of work to implement though since we do have a large
number of users of this interface already.



On Sun, 5 Sep 2004 22:50:36 +0200, Olivier Biot  wrote:
> IMHO the private_data portion should not be a void * but instead it
> should contain a reference to the protocol that set the private_data
> structure, together with the protocol-specific private data. Maybe we
> should envisage a linked list or hash with the protocol handle and the
> protocol data as members? That'd be much safer than the "don't use
> private_data unless you're 100% acquainted with what could happen".
> 
> Best regards,
> 
> Olivier
> 
> 
> 
> ----- Original Message -----
> From: Ronnie Sahlberg
> 
> | I belive there should always be a pinfo->private data for dcerpc
> protocols.
> |
> | One could encapsulate this inside
> |     if(pinfo->private_data)
> | but it would be better to try to see exactly why pinfo->private_data
> is NULL.
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev



*********************************************************************
This e-mail and any attachment is confidential. It may only be read, copied and used by the intended recipient(s). If you are not the intended recipient(s), you may not copy, use, distribute, forward, store or disclose this e-mail or any attachment. If you are not the intended recipient(s) or have otherwise received this e-mail in error, you should destroy it and any attachment and notify the sender by reply e-mail or send a message to sysadmin@xxxxxxxxxxx
*********************************************************************

<<winmail.dat>>