Re: [Ethereal-dev] Bug report: crash in packet-dcerpc-ndr.c

[ronnie sahlberg <ronniesahlberg@xxxxxxxxx>]

Yes, definitely.

the pinfo->private_data interface is suboptimal and error prone.

It would be better to change this to some sort of list of  protocol,data  pairs
which can be searched. 
It would be a lot of work to implement though since we do have a large
number of users of this interface already.



On Sun, 5 Sep 2004 22:50:36 +0200, Olivier Biot  wrote:
> IMHO the private_data portion should not be a void * but instead it
> should contain a reference to the protocol that set the private_data
> structure, together with the protocol-specific private data. Maybe we
> should envisage a linked list or hash with the protocol handle and the
> protocol data as members? That'd be much safer than the "don't use
> private_data unless you're 100% acquainted with what could happen".
> 
> Best regards,
> 
> Olivier
> 
> 
> 
> ----- Original Message -----
> From: Ronnie Sahlberg
> 
> | I belive there should always be a pinfo->private data for dcerpc
> protocols.
> |
> | One could encapsulate this inside
> |     if(pinfo->private_data)
> | but it would be better to try to see exactly why pinfo->private_data
> is NULL.
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>