Re: [Ethereal-dev] Patch to get the Win32 build to work again

[Lars Roland <lars.roland@xxxxxxx>]

Hello Yaniv,

Yaniv Kaul wrote:
> Well, one can't <rant< </rant> all the time.
> Trying to get the Win32 build to work:
>
> 1. distclean: It doesn't seem to delete all the object files in the root 
> dir that are a result of a compilation of $(DISSECTOR_SUPPORT_SRC) - 
> defined in epan\Makefile.common.
> Why is it in epan\Makefile.common, and the files are not in epan but in 
> the root is beyond me. One of them (the location of the files or the 
> decleration in the right Makefile) is probably wrong.

AFAIK it is a remnant of making libethereal a shared library on Linux. 
epan/Makefile.common will be removed when the dissector support files 
moved to epan/dissector.

> 2. Anyway, changing the definition from:
> DISSECTOR_SUPPORT_SRC =    \
>    adler32.c    \
> ...
>
> to:
> DISSECTOR_SUPPORT_SRC =    \
>    ../adler32.c    \

Strange, the prefix "../" is already there for a long time.


> seemed to have solved the problem for now. I'm ashamed to say I failed 
> to understand this 'svn diff' stuff, so attached is the complete file :(
> I'd appreciate if anyone can tell me how to do it (under cygwin or via 
> RapidSVN).
>
> It also made distclean work almost right - just need to get rid of 
> epan\print.obj and epan\ps.obj

print.c and ps.c were part of DISSECTOR_SUPPORT_SRC for some time but 
that changed recently. With this change distclean doen't remove 
epan\print.obj and epan\ps.obj anymore, because these files are expected 
to be in the main directory.
Another recent patch to makefile.nmake and epan/makefile.nmake changed 
this for all other DISSECTOR_SUPPORT_SRC files, too. Their object files 
will go into the main directory and distclean will remove the files only 
there.
We probably should think about making distclean and clean removing any 
file with extension obj, regardless of there is a corresponding source 
file or not.

Regards,
Lars