RE: [Ethereal-dev] Ask for correction

["Christophe Stoeckel" <c.stoeckel@xxxxxxxxxxx>]

Modification description :

* packet-bssap.c :
function 'dissect_bssap_heur' accept same frames that are not bssap frames.
The test in this function was completed (according to bssap requirement) to
correct this problem. The rules used to complete the test are explained in
the code.

* packet-ranap.c :
function 'dissect_sccp_ranap_heur' does not take account of PER format
length in RANAP message. If 'dissect_sccp_ranap_heur' function use
'extract_length' function to get length field value (it is used by ranap
dissector), then the problem is resolved.

Regards,
Christophe

-----Message d'origine-----
De : ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]De la part de Joerg Mayer
Envoye : mardi 3 aout 2004 14:30
A : Ethereal development
Objet : Re: [Ethereal-dev] Ask for correction


On Tue, Aug 03, 2004 at 02:19:00PM +0200, Christophe Stoeckel wrote:
> I would like to propose modification of bssap and ranap dissector to
> complete their "heuritical" function.
> I downloaded the source code from Ethereal's anonymous SVN repository and
> did code modification but
> what is the procedure to commit code modification ?

Please send your changes as unified diff plus a short description to
ethereal-dev@...

thanks
      Joerg

--
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev

Attachment: packet-ranap.diff
Description: Binary data

Attachment: packet-bssap.diff
Description: Binary data