Re: [Ethereal-dev] Changes for sip-t decoding

[Lars Roland <Lars.Roland@xxxxxxx>]

Hello Chernishov,

You should check your SIP Client's implementation. There is probably a 
bug in the SIP stack. The SIP Request Messages in your tracefile (Frames 
7, 29 and 35) aren't constructed correctly (See RFC 3261 Section 7).

As RFC 3261 sais, the Request-URI MUST NOT contain unescaped spaces.

You should not patch Ethereal to enable it to dissect RFC violating 
packet content. Ethereal does already a good job in just dissecting it 
as unknown data.
So I would reject your patch for the sip dissector. I haven't analyzed 
the ISUP patch as I am not familiar with it.

Note:

You should send patches instead of whole source files. You can use
"diff -u original_source/packet-foo.c modified_source/packet-foo.c" to 
generate patches. On Windows you can use Cygwin's port of diff.

Regards,

Lars



Chernishov Yury wrote:
> Hello!
> I'm working on SIP-T testing now and I see, that ethereal decoding of this
> protocol doesn't works <<packet-isup.c>>  <<packet-multipart.c>>  
> <<packet-sip.c>> 
> correct. I send you my changes and some traces. 
> If in is necesary - I can answer on any question about reason of changes.
>
> I don't now exactly ethereal development procedure,
> can you explain me this? 
> I can work on sip-t decoding in future also!
>
> Best regards!
> Chernishov Yury,
> Telecommunication testing team manager,
> IskraUralTel,
> Ekaterinburg, Russia.
>
>
>
>
>  <<IP_Phone(SSW1)_IP_Phone(SSW2)>> 
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev