Re: [Ethereal-dev] patch for gtk assertion and compiling error with MSVC6

[Guy Harris <guy@xxxxxxxxxxxx>]

On Sun, Oct 05, 2003 at 08:21:38PM +0200, Lars Roland wrote:
> packet-ansi_map.c doesn't compile with MSVC6. 
> It doesn't like static const value_string arrays with unknown size, like in
> line 127, 128 and 129.
> You have to initialize them. 

Checked in.  (Is there some option to make GCC more pedantic than it is
by default, so as to disallow most of the whizzo exclusive-to-GCC
extensions, but not so pedantic that it whines about anything other than
strictly-conforming programs, which Ethereal is incapable of ever
being, and not so strictly as to disallow the ones we protect with
#ifdefs and the like, such as the __attribute__ stuff to say "this
function is printflike" or "this is an unused parameter?)

> A GTK assertion was thrown, when I tried to use the new RTP Statistics on
> Win32.

The right fix there is probably to revert to using "gtk_dialog_new()",
not to create *two* windows and do nothing with the first one other than
setting its title:

> Index: ethereal/gtk/rtp_stream_dlg.c
> ===================================================================
> RCS file: /cvsroot/ethereal/gtk/rtp_stream_dlg.c,v
> retrieving revision 1.3
> diff -u -r1.3 rtp_stream_dlg.c
> --- ethereal/gtk/rtp_stream_dlg.c	26 Sep 2003 22:29:42 -0000	1.3
> +++ ethereal/gtk/rtp_stream_dlg.c	5 Oct 2003 17:15:59 -0000
> @@ -470,6 +470,7 @@
>  	rtpstream_dlg_w = gtk_window_new (GTK_WINDOW_TOPLEVEL);
>  	gtk_window_set_title (GTK_WINDOW (rtpstream_dlg_w), "Ethereal: RTP Streams");
>  	
> +	rtpstream_dlg_w = gtk_dialog_new();
>  	dialog_vbox1 = GTK_DIALOG (rtpstream_dlg_w)->vbox;
>  	gtk_widget_show (dialog_vbox1);
>  	

so I've checked in a change to do that.