Re: [Ethereal-dev] Re: [Ethereal-cvs] cvs commit: ethereal packet-dcerpc-samr.c

[Tim Potter <tpot@xxxxxxxxx>]

On Sun, Feb 02, 2003 at 03:13:43PM -0800, Guy Harris wrote:

> On Mon, Feb 03, 2003 at 09:53:14AM +1100, Tim Potter wrote:
> > I'm in the process of refactoring all the string handling routines for
> > the dcerpc dissectors.  It's a bit of a mess at the moment...
> 
> While you're looking at string handling, it might be interesting to see
> if, instead of the current (resuscitated) scheme in which a count of
> levels up the tree with which to decorate items with a string name is
> supplied, a way in which the dissector for the top-level item could
> somehow say "decorate me and all the other items below me".

Hmm.  That would be much easer than teaking count values.

> BTW, in some cases you get stuff such as this, in a SAMR LookupDomain
> request:
> 
>     Domain: XXXXX
>         Domain: XXXXX
>             Length: 10
>             Size: 12
>             Domain: XXXXX
>                 Referent ID: 0x08066d20
>                 Max Length: 6
>                 Offset: 0
>                 Length: 5
>                 Domain: XXXXX
> 
> Is there really one extra level of pointer in there, so that you get the
> extra "Domain:" header at the top?

There isn't really an extra level at the top so it's just a display bug.
I expect there will be a bit of cleaning up cosmetic bits and pieces as
I don't have captures for every individual RPC.

With the new code it should look something like this:

	Domain: XXXX
		Length: 10
		Size: 12
		Character Array: XXXX
			Referent ID: 0x12345678
			Max Length: 6
			Offset: 0
			Length 5
			Buffer: 47005200....

which minimises repetition which used to be there before and looks a lot 
nicer I think.


Tim.