Re: [Ethereal-dev] Unused function parameters: Request for help

[Guy Harris <guy@xxxxxxxxxx>]

On Tue, Apr 02, 2002 at 01:28:11AM +0200, Joerg Mayer wrote:
> I don't think that removing the unused variables would be helpful:

Presumably you meant "unused arguments".

> The function types would change (some of which are used in
> packet-hclnfsd.c).

And in a lot of other places, as is the case with
"dissect_rpc_uint32()".

I guess the questions are, for the low-level RPC item dissector
routines:

	1) whether we'd ever expect them to need anything from "pinfo"
	   (I suspect they'd never use it to add stuff to the Info column,
	   as they're probably too low-level to know enough about what
	   they're dissecting to put a high-enough-level description in the
	   Info column; I'm not sure they'd ever need it for anything else,
	   either);

	2) if not, whether we'd want to bite the bullet and just change
	   them and all its callers.