Re: [Ethereal-dev] Unicode strings ...

[Tim Potter <tpot@xxxxxxxxxxx>]

Richard Sharpe writes:

> > NT actually uses UCS2-LE (i.e 2 byte characters, little endian)
> > on the wire for the rpc calls.  So it's a bit more complicated
> > than having ustring calls.  )-:
> 
> Hmmm, but don't they look like lots of UCS2-LE characters, followed by 
> 0x000x00?
> 
> If so, I can handle these with a proto_tree_add_ustring_format or some such.

Yes - I was just pointing out that technically it should be
proto_tree_add_ustring_ucs2le_format().

> The question that remains is do we want to be able to handle different 
> Unicode formats? That is, will we need to handle other protocols that 
> may have different on-the-wire formats? If so, do we want to allow for 
> them now?

That's up to you guys I guess.  Personally I would probably go
for a proto_tree_add_ustring_format() function that only does
UCS2-LE and then when other protocols require different unicode
formats break the functions out in to more specific versions.


Tim.