Re: [ethereal-dev] can people try out this scroll patch

[Guy Harris <gharris@xxxxxxxxxxxx>]

> > Too bad the "set the point" stuff just provoked GTK+ to drop core.
> 
> Really? I haven't had any trouble with it. Kindof strange. The only time
> I've seen trouble is when changes are done with the text frozen.

I was referring to the stuff from:

> From: "Neulinger, Nathan R." <nneul@xxxxxxx>
> To: "'Guy Harris'" <gharris@xxxxxxxxxxxx>
> Cc: ethereal-dev@xxxxxxxx
> Subject: RE: [ethereal-dev] patch to have ethereal scroll bold text into view
> Date: Tue, 16 Nov 1999 08:41:39 -0600
> 
> > > Does anyone know how to set the scroll position of a 
> > GtkText while it is 
> > > frozen? That is the core of the problem - normally doing 
> > the inserts will 
> > > scroll the cursor into position. I tried doing various things with 
> > > setting the adjustment value, but it seems that this just 
> > causes crashes, 
> > > so I'm probably not doing it right. 
> > 
> > If the crashes are in the middle of the text widget, it's probably the
> > text widget that's not doing something right.  An attempt of mine to
> > have the text widget move to show the selected field's data when a new
> > field is selected (an "#if"ed-out version of which got checked into
> > "gtk/main.c" at one point - look for the stuff that a recent 
> > checkin of
> > mine deleted) caused plenty of crashes inside GTK+'s text widget.
> 
> It crashed pretty much the same way your stuff cored. The patch I attached
> does work (and doesn't trigger a core in my testing), but could probably be
> rewritten at some point to eliminate the unnecessary flicker. (My note might
> not have been particularly clear.)

not to your changes - so far, I haven't seen the changes you posted
crash, but I haven't done more than just play with them a bit so far. 
(A lot of the use I make of Ethereal is testing changes I'm making, so I
may not be the best tester in that regard; when I install 0.7.9 at work,
I'll add your patch in, so that it'll get a bit more stress.  The stuff
I'm doing at work right now isn't in the networking part of the code, so
others are more likely to stress it.)

> > I think I've seen it drop core even *without* the help of that code,
> > though, once - I think I'd selected a field whose text in the hex window
> > was scrolled offscreen, or something, and *blammo*.
> 
> Get me a trace if you could.

Again, the "it" wasn't your code - I'd seen it drop core in a version
that *didn't* have your changes in it.